Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When masquerade is set on bridge, add an iptables rule to drop #817

Closed
wants to merge 4 commits into from

Conversation

mccv1r0
Copy link
Member

@mccv1r0 mccv1r0 commented Jan 20, 2023

When masquerade is set on bridge, add an iptables rule to drop packets that conntrack considers invalid.

When portmap is used in chain, do likewise.

Use container specific IP addresses in rules so that only this rule is removed in cniDel

Allow for portmap and ipMasq to co-exist or used independently

Fixes #816

Signed-off-by: Michael Cambria mcambria@redhat.com

@mccv1r0 mccv1r0 force-pushed the ct-rst branch 5 times, most recently from dc80754 to 9edb7c5 Compare January 26, 2023 19:22
…ckets which conntrack consideres invalid.

When portmap is used in chain, do likewise.

Use container specific IP addresses in rules so that only this rule is removed in cniDel

Allow for portmap and ipMasq to co-exist or used independently

Fixes containernetworking#816

Signed-off-by: Michael Cambria <mcambria@redhat.com>
Signed-off-by: Michael Cambria <mcambria@redhat.com>
Signed-off-by: Michael Cambria <mcambria@redhat.com>
@mccv1r0 mccv1r0 force-pushed the ct-rst branch 7 times, most recently from aca6f0e to c5bc1ce Compare January 27, 2023 22:49
…ce per address

not once for all addresses.  Just do address/family specific processing

DEBUG: teardown ipv6 rules even when we know config doesn't have ipv6
       ipv4 rules don't seem to get removed when just calling teardown for ipv4
Log if no IP addr supplied to teardown
Log the IP addr used on failing cniDel
Only run tests which support the parsing needed

Signed-off-by: Michael Cambria <mcambria@redhat.com>
@github-actions
Copy link

github-actions bot commented Apr 1, 2023

This PR has been untouched for too long without an update. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 1, 2023
@github-actions github-actions bot closed this Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop invalid conntrack packets
1 participant